Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate async SFTP sensor #1470

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Deprecate async SFTP sensor #1470

merged 3 commits into from
Feb 16, 2024

Conversation

pankajkoti
Copy link
Collaborator

Deprecate SFTPSensorAsync and proxy it to its Airflow
OSS provider's counterpart

closes: #1419

@pankajkoti
Copy link
Collaborator Author

This needs to wait for the upstream provider PR to be released apache/airflow#37117

@pankajkoti pankajkoti mentioned this pull request Feb 2, 2024
1 task
Copy link
Contributor

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once upstream provider version updated here

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17078e1) 98.28% compared to head (df4ab46) 98.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1470      +/-   ##
==========================================
- Coverage   98.28%   98.27%   -0.01%     
==========================================
  Files          91       91              
  Lines        4662     4648      -14     
==========================================
- Hits         4582     4568      -14     
  Misses         80       80              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pankajkoti pankajkoti marked this pull request as ready for review February 12, 2024 12:05
@pankajkoti pankajkoti marked this pull request as draft February 12, 2024 12:37
@pankajkoti pankajkoti force-pushed the deprecate-sftp-sensor branch from cbd8006 to d2c9f07 Compare February 14, 2024 08:36
setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@pankajkoti pankajkoti marked this pull request as ready for review February 16, 2024 07:58
@pankajkoti pankajkoti merged commit 8b691f1 into main Feb 16, 2024
11 checks passed
@pankajkoti pankajkoti deleted the deprecate-sftp-sensor branch February 16, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate sftp async provider
4 participants